Update handling of missing kernel headers to better reflect warning status#2250
Draft
ddelnano wants to merge 2 commits intopixie-io:mainfrom
Draft
Update handling of missing kernel headers to better reflect warning status#2250ddelnano wants to merge 2 commits intopixie-io:mainfrom
ddelnano wants to merge 2 commits intopixie-io:mainfrom
Conversation
…tatus Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Update handling of missing kernel headers to better reflect warning status
The
pxcli was updated to include a warning when it detected that a cluster didn't have kernel headers installed. The initial implementation reused the same UI elements that the cli included and therefore the "warning" was printed with red text prefixed withERR:(as seen below).This was harsher than intended and could cause confusion for users that otherwise have a working cluster. This PR updates the warning with yellow text and a more appropriate prefix (
WARN:) and links to documentation (added in pixie-io/px.dev#111) that provides more detail.Relevant Issues: #2051
Type of change: /kind bugfix
Test Plan: Deployed a new vizier that failed the check and verified the text is no longer red and links to documentation